search

odlgroup / odl

Operator Discretization Library https://odlgroup.github.io/odl/
Mozilla Public License 2.0
353 stars 103 forks source link

Propagation of tests in diagnostics #339

Open adler-j opened 8 years ago

adler-j commented 8 years ago

Currently diagnostics run on a nonlinear operator does not test that the derivatives work "as expected". Is this something we should investigate?

The same applies to the adjoint of linear operators, which are currently not fully tested (we only test the adjoint specific things).

Should we perhaps add a "level" to the run_tests thing?

kohr-h commented 8 years ago

Currently diagnostics run on a nonlinear operator does not test that the derivatives work "as expected". Is this something we should investigate?

I don't follow. What have we been talking about in #334? What do you mean by "as expected"?

The same applies to the adjoint of linear operators, which are currently not fully tested (we only test the adjoint specific things).

I guess you mean that we should test it just as any other linear operator?

Should we perhaps add a "level" to the run_tests thing?

We could also be more explicit about the individual methods offered to do specific kinds of tests, i.e. the class doc could name the relevant public test methods explicitly.

Then, I think it would make sense to rename the methods a bit. The current run_tests could be test_all, and the other, more specific tests could be named test_derivative and similar.

kohr-h commented 7 years ago

How about this?

adler-j commented 7 years ago

Diagnostics is in a mess currently and hasn't been touched in a long time. We should give it a major facelift and this is part of it. We could however use an overall issue that guides the effort.