search

odlgroup / odlcuda

C++ backend for ODL
GNU General Public License v3.0
5 stars 2 forks source link

Change from boost to pybind11 #12

Open adler-j opened 8 years ago

adler-j commented 8 years ago

PyBind11 is an alternative to boost python that does not require a compiled part (and the rest of boost), this would simplify compilation and distribution by PyPI.

kohr-h commented 8 years ago

Looks very nice indeed.

adler-j commented 8 years ago

There is a branch for this out now. Compilation times are down drastically and we no longer need a boost dependency, instead we have PyBind11 as a submodule, but there are some issues. It does seem PyBind11 is actively maintained so they could be fixed soon.

EDIT: 5 tests still fail, one serious (index error not raised), and a few less serious (getitem returns a long in python 2).

kohr-h commented 8 years ago

Sounds great so far. I'm sure the errors can be fixed upstream.

adler-j commented 8 years ago

Now 100% working, biggest (and really only) issue is that C++11 is not fully supported with VS2013, and CUDA does not work with VS2015. Currently, it works, so we can freeze at this commit of PyBind11 if we want, but if the author does some change that breaks VS2013, we cannot use that until CUDA catches up.

kohr-h commented 8 years ago

Ah these windows issues... Of course, we can freeze at the current state. When there is an upstream change, it's easy to just test and see if our systems cooperate with it.

kohr-h commented 8 years ago

I don't know if this conversation contains the latest issue which made us stall this, but now that CUDA 8 is out and VS15 support is there, perhaps it's time to reconsider?

adler-j commented 8 years ago

It certainly is. I'll look more at it in a while.

kohr-h commented 8 years ago

As for now, CUDA 8 hasn't hit the mainstream Linux distro repos yet, so there's no need for a rush.