search

odnoklassniki / ok-android-sdk

Android SDK & samples for native apps integrated with OK.RU
Apache License 2.0
20 stars 28 forks source link

Revert min sdk version to 9 #15

Closed KovalevAndrey closed 7 years ago

KovalevAndrey commented 7 years ago

A few releases ago minSdk version was changed to 16 however it can perfectly work with minSdk=9 without any issues. I just ran lint with minSdk = 9 and no issues were found. I suggest to revert minSdk verion to 9. It will allow more projects to use OK sdk

lintax commented 7 years ago

According to https://developer.android.com/about/dashboards/index.html API level 15 does not suit just for 1.3% of all android user base. While not objecting the use of the lowest possible API level (9 is minimal requirement for now), I hardly see the real reason to keep it so low, especially when you can use library from your fork if you really need level 9.

So, let's see what will @thefilin say about the request.

afarber commented 7 years ago

Why 15 and not 14? Google has recommended 14 recently: https://android-developers.googleblog.com/2016/11/google-play-services-and-firebase-for-android-will-support-api-level-14-at-minimum.html

KovalevAndrey commented 7 years ago

Some projects still use minSdk lower than 16. For instance, Avito project uses minSdk =15. We can't use your updated sdk which uses acitvity for result instead of callbacks. It brings us a lot of pain. We would be happy even with minSdk =15. But there were no issues even with minSdk =9 that's why I suggested it

KovalevAndrey commented 7 years ago

Also there's such thing as semver. I assume it's inappropriate to increase minSdk that much in a minor update

thefilin commented 7 years ago

I think, we can do it. Merged. Thanks!

KovalevAndrey commented 7 years ago

That's great! When do you think a new version will be released?

thefilin commented 7 years ago

Usually it takes a few hours.

KovalevAndrey commented 7 years ago

Thanks a lot