search

odnoklassniki / one-nio

Unconventional I/O library for Java
Apache License 2.0
655 stars 97 forks source link

Getters for all the set socket options #44

Closed avrecko closed 5 years ago

avrecko commented 5 years ago

Imho pretty obvious to have.

avrecko commented 5 years ago

Build failed because test used a hardcoded port that was in use. Using an arbitrary free port instead. All good now.

avrecko commented 5 years ago

I've cleaned up some of the native code for getters.

In the http tests, sometimes the HttpClient requests happen faster than the AcceptorThread starts. In such cases there is Connection refused exception (in native impl there is no wait/retry).

I think it would be cool if the Server had a blocking start method (block until acceptors are up and running) and a way to query if acceptors are running. What do you think? Something like Server#startSync() and Server#isAcceptingRequests().

apangin commented 5 years ago

I agree, it's better to just make start synchronous with the acceptor threads. I've committed the fix (along with some other small fixes from our internal repo).

apangin commented 5 years ago

Thank you for addressing all the review comments - the PR has finally got merged.

avrecko commented 5 years ago

It is a pleasure to work with this library. Thank you for making it available on GitHub.

On Sun, 9 Jun 2019 at 14:25, Andrei Pangin notifications@github.com wrote:

Thank you for addressing all the review comments - the PR has finally got merged.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/odnoklassniki/one-nio/pull/44?email_source=notifications&email_token=AACRDOLXR7D443WDPPEJKL3PZTZE3A5CNFSM4HQGGR2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIJDXQ#issuecomment-500208094, or mute the thread https://github.com/notifications/unsubscribe-auth/AACRDON4PETHB5U75QFQNVTPZTZE3ANCNFSM4HQGGR2A .