search

odo-devfiles / registry

A repository of devfile 2.0 stacks for odo
7 stars 33 forks source link

Remove discoverable key #14

Closed cdrage closed 4 years ago

cdrage commented 4 years ago

Key is not supported by schema / not available upstream.

Signed-off-by: Charlie Drage charlie@charliedrage.com

kadel commented 4 years ago

More changed in endpoints definition than just discoverable. The whole configuration field is gone and it was replaced with the Exposure field.

We can't just introduce new fields into the endpoints as the devfile spec is not updated in odo. At this point, it might be best to just remove the whole configuration section. The ports be still defined in devfile, and it won't break odo. We can add the extra arguments back once they are implemented in odo

kadel commented 4 years ago

Opened https://github.com/odo-devfiles/registry/pull/21 to remove whole configuration field in all devfiles