search

odo-devfiles / registry

A repository of devfile 2.0 stacks for odo
7 stars 33 forks source link

Update quarkus devfile with `hotreloadcapable` #43

Closed adisky closed 4 years ago

adisky commented 4 years ago 
attribute:
  restart: false

is replaced by hotReloadCapable: true

PR for the same has been merged in upstream odo.

https://github.com/openshift/odo/pull/3785

anandrkskd commented 4 years ago

@adisky hotReloadCapable property is breaking CI, for example: https://travis-ci.com/github/odo-devfiles/registry/builds/183281814#L2225 , https://travis-ci.com/github/odo-devfiles/registry/builds/183137199#L5556. Even this PR should have been failed https://travis-ci.com/github/odo-devfiles/registry/builds/182061027#L1889 but didn't due to wrong syntax on https://travis-ci.com/github/odo-devfiles/registry/builds/182061027#L2678. but when I tried on local it was not failing. cc: @kadel