renamed the endpoint from 8080/http to 8080-http to make it adapter friendly

odo-devfiles / registry

A repository of devfile 2.0 stacks for odo

7 stars 33 forks source link

renamed the endpoint from 8080/http to 8080-http to make it adapter friendly #58

Closed girishramnani closed 4 years ago

girishramnani commented 4 years ago

So the 8080/http would be an invalid when used in a url slug due to the /. Now odo is smart enough to change that to 8080-http but then adapter also has to do that. So for a quick fix I have renamed 8080/http to 8080-http, this is not a solution. Solution could be mostly around failing the url name validation but I also like that odo is smart so while we get to conclusion a quick fix to unblock adapters.

girishramnani commented 4 years ago

not sure why these tests are failing

I could see the debugger not working on any java devfiles but that doesn't look like something this PR did
I can see the url check passing
its hard to see which devfile failed in this test

girishramnani commented 4 years ago

cc @kadel