search

odo-devfiles / registry

A repository of devfile 2.0 stacks for odo
7 stars 33 forks source link

Update node.js default ubi image #64

Closed aalykiot closed 3 years ago

aalykiot commented 3 years ago

Recently the Red Hat Software Collections released the node.js-14 UBI image (since this is an LTS version, should be fine to use it as the default image on devfiles).

Since we don't know how you guys bump devfiles versions we left that unchanged (v1.0.0). If I also have to bump the version in this PR please let me know.

BethGriggs commented 3 years ago

I'm guessing this may need to wait until https://github.com/openshift/odo/issues/4303 is resolved?

BethGriggs commented 3 years ago

Would someone with permissions be able to rerun CI, please? As discussed elsewhere, the test failures do not appear to be from the Node.js DevFile

elsony commented 3 years ago

LGTM

I rerun the test and it is passing now. The version number increment is up to the stack. In general, we recommend SemVer.

I'm guessing this may need to wait until openshift/odo#4303 is resolved?

I haven't merged this one yet based on this comment.

elsony commented 3 years ago

@dharmit @kadel This PR changes the major version of the nodejs stack. I don't think it will break odo test automation but I just wanted to confirm with you before merging. Can you confirm?

dharmit commented 3 years ago

@elsony I think odo CI will be fine with this change because we're mostly storing the devfiles and example repos' source locally on the odo repo to avoid pulling from GitHub numerous times.

I'm guessing this may need to wait until openshift/odo#4303 is resolved?

I haven't merged this one yet based on this comment.

That issue and its related PRs are about adding nodejs-14 as supported image. nodejs-12 is already in list of supported images since we merged https://github.com/openshift/odo/pull/4070.

BethGriggs commented 3 years ago

That issue and its related PRs are about adding nodejs-14 as supported image. nodejs-12 is already in list of supported images since we merged openshift/odo#4070.

I'm a little confused by this comment, as this PR is updating the DevFile to default to nodejs-14.

dharmit commented 3 years ago

I'm a little confused by this comment, as this PR is updating the DevFile to default to nodejs-14.

Ah, my bad. I'm not sure why my brain read it as 12:latest instead of 14-latest. :man_facepalming:

kadel commented 3 years ago

That issue and its related PRs are about adding nodejs-14 as supported image. nodejs-12 is already in list of supported images since we merged openshift/odo#4070.

That PR is completely unrelated to this. https://github.com/openshift/odo/pull/4070 affects only s2i builder images, it has nothing to do with Devfiles