search

odoe / generator-arcgis-js-app

Generator for ArcGIS JS API applications
42 stars 9 forks source link

Mocha fixes #16

Closed tomwayson closed 8 years ago

tomwayson commented 8 years ago

When working on #13 I noticed that running the generator's own mocha tests failed. I fixed the failing test and then added tests to check for copied files and templated content. This will help w/ developing #10.

Also, I changed the default package name to be dasherized ("my-app") instead of classified (MyApp) b/c npm no longer accepts caps in the package names.

tomwayson commented 8 years ago

Oh and I added a few Travis CI targets. Would be good to wire this up to Travis now that the tests are passing to get that feedback for future PRs.

odoe commented 8 years ago

Is this ready to merge? I went ahead and added you as a collaborator for the repo. I think that gives you merge access. Let me know if it works.

Thanks! @tomwayson!

tomwayson commented 8 years ago

@odoe thanks for the :key:s!

Would be great to set up travis now that we've got passing tests, but I'm pretty sure that only you can do that.

tomwayson commented 8 years ago

@odoe

also, prob should tag a release now that this is merged as it did slightly change app behavior in addition to adding tests.