search

odoe / generator-arcgis-js-app

Generator for ArcGIS JS API applications
42 stars 9 forks source link

Incorrect folder with multiple languages #18

Closed RiemerBug closed 8 years ago

RiemerBug commented 8 years ago

If I add another language to includeLocales: ['en-us', 'de'] in the build.profile.js, in my case de.  moment_de.js will load from the wrong place (outside the release folder)

odoe commented 8 years ago

Thanks for reporting this! I've done some local testing and I think I figured this out. I'll push a patch out today.

The fix is to update the path of the defaultConfig

odoe commented 8 years ago

oops, stupid tab

Update the paths for defaultConfig

  defaultConfig: {
    parseOnLoad: true,
    deps: ['app/main'],
    hasCache: {
      'extend-esri': 0,
      'dojo-has-api': 1,
      'dojo-undef-api': 0
    },
    paths: {
      'app/config': './config',
      'esri/layers/vector-tile': './vector-tile',
      'moment': './moment' // add this
    }
  }

It will then point the moment directory correctly.

Only problem here is that you would need to include all locales you want to support into your built app, which may not be desirable. This leads me to think I should add an option to not copy the built dojo/dojo.js into the app.js so that you could still lazy load the locales as needed.

I'll test more on that enhancement and see if I could still create the cache busted app.js but still have all the other files available for lazy loading.

Thanks!

odoe commented 8 years ago

This should be fixed here https://github.com/odoe/generator-arcgis-js-app/commit/3373558ba3dab3358e639fd020c184af093eb4ad