search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

Fix Symfony 6.1 deprecation for `PhoneNumber` constraint #110

Closed norkunas closed 2 years ago

Nek- commented 2 years ago

Note: the break must be notified inside the changelog.

I'm not against this commit (meaning go for merge) but I'd prefer to keep compatibility with the deprecation comment since it's super easy.

norkunas commented 2 years ago

Note: the break must be notified inside the changelog.

I'm not against this commit (meaning go for merge) but I'd prefer to keep compatibility with the deprecation comment since it's super easy.

Changelog updated

Nek- commented 2 years ago

Sorry I finally changed my mind. Also I don't think it's a break so the changelog should omit this part.

Maybe I'm wrong so I'm waiting for an answer from @jderusse . :)

norkunas commented 2 years ago

No problem :) will update in next hour

2022-06-01, tr 11:53, Maxime Veber @.***> rašė:

@.**** commented on this pull request.

In src/Validator/Constraints/PhoneNumber.php https://github.com/odolbeau/phone-number-bundle/pull/110#discussion_r886556527 :

     self::INVALID_PHONE_NUMBER_ERROR => 'INVALID_PHONE_NUMBER_ERROR',

];

  • protected static $errorNames = self::ERROR_NAMES;

@norkunas https://github.com/norkunas sorry for making you go and back. But we're finally in an agreement!

— Reply to this email directly, view it on GitHub https://github.com/odolbeau/phone-number-bundle/pull/110#discussion_r886556527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUYYOC3EUX2ZQSEANB4JBTVM4QHNANCNFSM5WVJXJ5Q . You are receiving this because you were mentioned.Message ID: @.***>

Nek- commented 2 years ago

Thank you very much for this @norkunas ! 😊

OskarStark commented 2 years ago

Can we get a release here ?

Nek- commented 2 years ago

@OskarStark with pleasure! I just need an approve :) . https://github.com/odolbeau/phone-number-bundle/pull/115