Closed Nek- closed 2 years ago
Should we add a doctrine/annotation conflicts <= 1.12 for NamedArgumentConstructor ?
This is actually a good question I didn't test this with low dependencies. I'm going to try this. Anyway, If it doesn't work with doctrine/annotation <= 1.12
I'm more in favor of enforcing the dependency than adding it in the conflict section.
So, to test with a low version of doctrine annotations here is the required composer.json:
{
"type": "project",
"license": "proprietary",
"require": {
"php": ">=7.1.3",
"ext-ctype": "*",
"ext-iconv": "*",
"doctrine/annotations": "1.11.2",
"doctrine/doctrine-bundle": "^2.2",
"doctrine/doctrine-migrations-bundle": "^3.2",
"doctrine/orm": "2.8.5",
"odolbeau/phone-number-bundle": "^3.6",
"sensio/framework-extra-bundle": "^6.2",
"symfony/console": "4.4.*",
"symfony/dotenv": "4.4.*",
"symfony/flex": "^1.3.1",
"symfony/form": "4.4.*",
"symfony/framework-bundle": "4.4.*",
"symfony/maker-bundle": "^1.39.0",
"symfony/proxy-manager-bridge": "4.4.*",
"symfony/security-csrf": "4.4.*",
"symfony/validator": "4.4.*",
"symfony/yaml": "4.4.*"
},
"config": {
"allow-plugins": {
"composer/package-versions-deprecated": true,
"symfony/flex": true
},
"preferred-install": {
"*": "dist"
},
"sort-packages": true
},
"autoload": {
"psr-4": {
"App\\": "src/"
}
},
"autoload-dev": {
"psr-4": {
"App\\Tests\\": "tests/"
}
},
"replace": {
"paragonie/random_compat": "2.*",
"symfony/polyfill-ctype": "*",
"symfony/polyfill-iconv": "*",
"symfony/polyfill-php71": "*",
"symfony/polyfill-php70": "*",
"symfony/polyfill-php56": "*"
},
"scripts": {
"auto-scripts": {
"cache:clear": "symfony-cmd",
"assets:install %PUBLIC_DIR%": "symfony-cmd"
},
"post-install-cmd": [
"@auto-scripts"
],
"post-update-cmd": [
"@auto-scripts"
]
},
"conflict": {
"symfony/symfony": "*"
},
"extra": {
"symfony": {
"allow-contrib": false,
"require": "4.4.*"
}
},
"require-dev": {
"symfony/stopwatch": "4.4.*",
"symfony/web-profiler-bundle": "4.4.*"
}
}
It hurts. But works like a charm 😁 .
Checkout issue #113 . It's specific to annotation usage.