search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

feat: drop support for Symfony 4.4 #141

Closed Chris53897 closed 11 months ago

Chris53897 commented 1 year ago

migrate phpunit config-format for v9.

Symfony 4.4 is no longer LTS https://symfony.com/releases/4.4 and should be droped in my eyes.

Any thoughts on dropping support of php < 8.0?

Nek- commented 1 year ago

Hello, thank you very much for your contribution. I agree that we can drop support for Symfony 4.4... As well as PHP < 8.0. But if we have no need or no new feature blocking (at least some test failing because of it, idk)... I don't like the idea of removing the support for it.

Chris53897 commented 1 year ago

I guess this PR should be splitted in separate PRs. The CI changes and testrun for php 8.2 are useful in my eyes.

jmsche commented 11 months ago

Hi, I think this PR can be closed as #158 dropped support for Symfony 4.4?