search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

New release ? #149

Closed julien-jourde closed 1 year ago

julien-jourde commented 1 year ago

Hello,

Any chance to have a new release with SF 6.3 deprecations solved ?

Have a nice day :)

Nek- commented 1 year ago

Definitely! Just to help me to have an idea of the work to be done, is master branch ok for you or are some things missing?

julien-jourde commented 1 year ago

For me, deprecations are fixed.

alex-itech1 commented 1 year ago

Definitely! Just to help me to have an idea of the work to be done, is master branch ok for you or are some things missing?

Hello. Are you planning to make a new release from the master branch ?

Because current tag is v3.9.1 (date 2023-01-16 11:06 UTC), it's too old, and it's without a fix for Symfony 6.3. Thus it's impossible to use this package with version tag in composer in my project (Symfony 6.3).

Thank you in advance @Nek-

maxhelias commented 1 year ago

@alex-itech1 I'm surprised, what are the BC in v3.9.1 ?

alex-itech1 commented 1 year ago

@maxhelias I'm afraid I don't understand your question.

I'm telling that the last version v3.9.1 is not working in Symfony 6.3.

https://github.com/odolbeau/phone-number-bundle/compare/v3.9.1...master Here we can see that v3.9.1 a little bit old and does not contain fixes for Symfony 6.3, thus I wonder to know if you could do a new fresh release with including the fix, please

maxhelias commented 1 year ago

So, There's nothing to block Symfony 6.3 from working. The fix concern only notice deprecation not breaking change.

FYI : https://github.com/odolbeau/phone-number-bundle/pull/150

maxhelias commented 1 year ago

v3.9.2 was release : https://github.com/odolbeau/phone-number-bundle/releases/tag/v3.9.2