search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

Allow Symfony 7 & drop support for unmaintained Symfony versions #158

Closed jmsche closed 11 months ago

odolbeau commented 11 months ago

Close #157

What a timing. ;)

jmsche commented 11 months ago

Oh sorry, I think you pushed it after I checked if there was an opened PR :sweat_smile:

odolbeau commented 11 months ago

No problem. ;)

jmsche commented 11 months ago

About PHP CS Fixer & PHPStan, what do you think about putting them in their own composer.json files in a tools directory? (can be done in a separate PR)

I did it in WebpackEncore bundle & a few others in the past, see e.g. https://github.com/symfony/webpack-encore-bundle

odolbeau commented 11 months ago

About PHP CS Fixer & PHPStan, what do you think about putting them in their own composer.json files in a tools directory? (can be done in a separate PR)

I did it in WebpackEncore bundle & a few others in the past, see e.g. https://github.com/symfony/webpack-encore-bundle

It avoid this kind of "problems" with docker images which are not (yet) up to date and it's pretty similar to what's proposed by cs-fixer, so it's OK for me! :ok_hand:

jmsche commented 11 months ago

It avoid this kind of "problems" with docker images which are not (yet) up to date and it's pretty similar to what's proposed by cs-fixer, so it's OK for me! 👌

Would you prefer an other PR for this?

odolbeau commented 11 months ago

It avoid this kind of "problems" with docker images which are not (yet) up to date and it's pretty similar to what's proposed by cs-fixer, so it's OK for me! 👌

Would you prefer an other PR for this?

Yes, if it's OK for you. :)

jmsche commented 11 months ago

Sure, I'll wait for this PR to be merged before :)

jmsche commented 11 months ago

Hi, may I ask for a new release? :smile:

odolbeau commented 11 months ago

It's coming in #166! :ok_hand: