search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

Increase PHPStan level #162

Closed odolbeau closed 11 months ago

odolbeau commented 11 months ago

This probably break the BC promise and its probably not complete : there's probably other non strict typed methods I should take care of.

WDYT about this, should we go for a new major version with strict typing? If yes, is there anything else we would like to include in a new major version?

maxhelias commented 11 months ago

I think we can go for a new major version, it's time to move on ;D

maxhelias commented 11 months ago

PhoneNumber::$errorNames Could be remove for a major version and it should fix the failed CI