odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

Request to make `symfony/framework-bundle` dependency optional #169

Closed daniser closed 8 months ago

daniser commented 8 months ago

I develop a package which uses symfony/serializer and symfony/validator components, but it is intended to be framework-agnostic. This bundle (which is neat btw :) depends on heavy symfony/framework-bundle which is not needed when developing outside the framework. Right now I added it in replace section of my composer.json, but this solution is... suboptimal.

I suggest to move symfony/framework-bundle into dev-dependencies instead, plus into suggestions. What do you think?

odolbeau commented 8 months ago

Hi @daniser! This package is a bundle which integrates giggsey/libphonenumber-for-php into Symfony. It's tight with Symfony (including symfony/framework-bundle) but it's on purpose. If you dont' want this requirement, you should probably consider to use the library directly.