search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

Allow empty PhoneNumber object to be transformed in form #179

Closed nicodemuz closed 1 week ago

nicodemuz commented 1 month ago

I have an entity that does not allow a NULL value for phone number:

    #[ORM\Column(type: 'phone_number', nullable: false)]
    #[AssertPhoneNumber]
    private PhoneNumber $phone;

This change allows an empty PhoneNumber object to be transformed to be displayed on the form.

odolbeau commented 2 weeks ago

Hi @nicodemuz & thanks a lot for your contribution!

I'm sorry for the very late answer! :see_no_evil:

Static analysis have bee corrected in #180, could you please rebase your branch?

nicodemuz commented 2 weeks ago

Hi @nicodemuz & thanks a lot for your contribution!

I'm sorry for the very late answer! 🙈

Static analysis have bee corrected in #180, could you please rebase your branch?

I have updated my branch. The tests are now passing.

odolbeau commented 1 week ago

Thanks for your contribution!