search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

feat: Add a feature to change country display format in form #95

Closed nicolassing closed 1 year ago

nicolassing commented 2 years ago

Hi ! If someone want to discuss about this PR, let me know :)

Nek- commented 1 year ago

Hello @nicolassing sorry for not taking the time to have a look, and thank you very much for your patience. This feature is nice and can be merged.

Can you add the (little) optimization I suggested?

Side note: please rebase your PR and squash your commit as soon as #134 is merged.

nicolassing commented 1 year ago

Hello @nicolassing sorry for not taking the time to have a look, and thank you very much for your patience. This feature is nice and can be merged.

Can you add the (little) optimization I suggested?

Side note: please rebase your PR and squash your commit as soon as #134 is merged.

I'll try to work on this week ! Thanks :)

Nek- commented 1 year ago

Thank you very much @nicolassing !