search

odolbeau / phone-number-bundle

Integrates libphonenumber into your Symfony application
MIT License
217 stars 43 forks source link

php8 return types compatible #99

Closed maikelohcfg closed 2 years ago

maikelohcfg commented 2 years ago

Updated methods return types for php8

maikelohcfg commented 2 years ago

Hello @Nek- thanks for your quick review and your opinion, based on that I have changed the native php 8 types on methods to annotation return types.

You are right, this PR remove Symfony deprecations alerts. I like to keep my projects clean of deprecations alerts, so I'm guilty 😜

Nek- commented 2 years ago

It have far more changes to be merged like this hehe. Thank you very much @maikelohcfg .

maikelohcfg commented 2 years ago

It have far more changes to be merged like this hehe. Thank you very much @maikelohcfg .

Community is not always about receive, we must contribute too. So thanks to you too.

maxhelias commented 2 years ago

@maikelohcfg Just one last thing please 🙏 Can you look at why PHP-CS-Fixer is not happy ? 🤔

maikelohcfg commented 2 years ago

@maxhelias done with php-cs-fixer