search

odolbeau / rabbit-mq-admin-toolkit

Manage a RabbitMQ cluster easily.
MIT License
84 stars 28 forks source link

Naming pattern #42

Open piotrbrzezina opened 5 years ago

piotrbrzezina commented 5 years ago

Hi

On the beginning, I want to thanks for this great library.

I would like to know your opinion about what you think about adding to the configuration the possibility of creating name patterns for the queue dl and retry curently thay are hardcoded to:

$retryQueueName = $name.'_retry_'.$retries[$i]; $this->createQueue($name.'_dl', array( $this->createQueue($name.'_delay_'.$delay, array(

maybe we can create config value that can be overridden in a config file for this hardcoded string? for example

parameters:
      dl_queue_patern: '%%queue_name%%_dl'
      retry_queue_patern: '%%queue_name%%_retry_%%retries%%'
      retry_queue_patern: '%%queue_name%%_delay_%%delay%%'

what do you think about that?

odolbeau commented 5 years ago

Hi @piotrbrzezina & thanks for your issue.

That's the great idea, don't hesitate to create a PR to add this new feature! :+1:

Just because I'm curious, can you describe your use case please? :)

piotrbrzezina commented 5 years ago

Thanks for the quick reply

in our project, we have established a strategy for creating names for queues but this strategy is incompatible with the names that are used in this library. And we don't want to change our agreements because of the library :)

I will back to you with PR soon