odolbeau / rabbit-mq-admin-toolkit

Manage a RabbitMQ cluster easily.
MIT License
84 stars 28 forks source link

Use Swarrot to publish messages #43

Closed stof closed 4 years ago

stof commented 4 years ago

Using the AMQP protocol is a lot faster than sending one POST request per message when sending messages in batch (by using a file in the message:sender command).

This is something I have since a very long time locally, when I became frustrated when sending big batches of messages with the toolkit.

As the VhostManager is not marked as @internal, I decided to keep the VhostManager::publishMessage method for now to avoid BC break, deprecating it instead (as the toolkit itself does not use it anymore).

odolbeau commented 4 years ago

Thanks! I think the publishMessage method is not heavily used. I'll take a look at tests later & get back to you when fixed.

stof commented 4 years ago

well, the only place where this package uses it was in the message:sender command, which is why I'm deprecating it. But given the VhostManager is not marked as @internal, it might be used in projects using the toolkit.

stof commented 4 years ago

tests are saying

$ sudo systemctl start rabbitmq-server

Failed to start rabbitmq-server.service: Unit rabbitmq-server.service not found.

So this looks like a Travis issue.

stof commented 4 years ago

and here is the explanation: https://travis-ci.community/t/is-rabbitmq-service-down/4362

stof commented 4 years ago

I opened https://github.com/odolbeau/rabbit-mq-admin-toolkit/pull/44 to try to fix it.