search

odolbeau / rabbit-mq-admin-toolkit

Manage a RabbitMQ cluster easily.
MIT License
84 stars 28 forks source link

Add #[ReturnTypeWillChange] attribute for FromArray::offsetGet #60

Open nemoipaha opened 1 year ago

nemoipaha commented 1 year ago

@odolbeau Hi! I need to temporarily suppress the notice that the latest implementation of FromArray class causes on my production. Is it ok If I make such a pr for you? I am using your package in a lot of places and such a warning is converted to ErrorException which is a bit inconvenient for my current production setup.

Shine-neko commented 9 months ago

@odolbeau ?

odolbeau commented 9 months ago

Hi @nemoipaha Thanks for your PR and sorry for the late response.

It looks like tests didn't run, could you please re-submit your PR? Thanks!