odoo-ide / pycharm-odoo

PyCharm plugin for Odoo
https://plugins.jetbrains.com/plugin/13499-odoo
Other
44 stars 5 forks source link

Plugin does not recognize xml_id when string is split in multiple lines #341

Open pnajman-modoolar opened 1 year ago

pnajman-modoolar commented 1 year ago

PyCharm version 2023.1 Odoo plugin version: 2023.3.4.231

Works for "normal" xml_id strings Selection_873

But it doesn't work when the xml_id string is split in multiple lines Selection_874

trinhanhngoc commented 1 year ago

Hi @pnajman-modoolar . I already know this problem. However, this case is rare, so I haven't support it yet. Are you using multilines XML IDs in real work?

pnajman-modoolar commented 1 year ago

Hi @pnajman-modoolar . I already know this problem. However, this case is rare, so I haven't support it yet. Are you using multilines XML IDs in real work?

Hi @trinhanhngoc,

Sometimes xml_ids can get get really long and then black will brake it down to match code line length rule.

This is not some everyday issue, but it can happen. No need for some high priority. It's for when you have some free time and nothing else to do :)

Cheers, Petar

jcfernandez-890825 commented 1 year ago

I have been doing some very long ones while using mapped method. For example when working with attribute values on product templates. So I have been forced to store the string on a variable, but then I then get a proper type guessing and all the other goodies.

So.... +1 to this.