odoo / docker

Other
956 stars 1.54k forks source link

allow change of the databe name via. Docker env var #358

Open zer0divisi0n opened 3 years ago

zer0divisi0n commented 3 years ago

https://github.com/odoo/docker/blob/f8212600f6478a15fac9ff3e7d8a926f78435860/14.0/wait-for-psql.py#L21

would it be possible to change the last connection parameter dbname='postgres' to dbname=args.db_name to allow changing the postgres database name

alexsegura commented 9 months ago

Yeah, this hardcoded database name makes me crazy.

amh-mw commented 9 months ago

14.0 is EOL, so you're out of luck for that version, but I put up a patch for 15.0-17.0 PR DOA

amh-mw commented 9 months ago

would it be possible to change the last connection parameter dbname='postgres' to dbname=args.db_name to allow changing the postgres database name

It's fine that it is hardcoded to postgres here. It's just checking to make sure that the postgres service is available.