search

odoo / docker

Other
932 stars 1.52k forks source link

use wkhtmltopdf from os supplied base apt source #399

Closed sanderkwantes closed 1 year ago

sanderkwantes commented 2 years ago

This fix ensures that odoo does not depend on an amd64 image. Apple Silicon M1 developers in particular are going to be happy about this. Docker containers are now created from an arm64 image for Apple Silicon Docker for Mac users. This eliminates the use of the more inefficient 'platform: linux/amd64' workaround.

sanderkwantes commented 2 years ago

The default included version of wkhtmltopdf in debian buster is in line with Odoo's recommended version: https://packages.debian.org/buster/wkhtmltopdf

floflock commented 2 years ago

+1 from my side for the arm64 image. However, obviously, the images are built and pushed manually to the docker hub?

Maybe we consider using Github Actions here for automatic build and push?

gustavovalverde commented 2 years ago

See here @em230418 @floflock https://github.com/odoo/docker/issues/376#issuecomment-1046174407

d-fence commented 1 year ago

I'm sorry to say that it will not work. The only supported wkhtmltopdf version is 0.12.5-1.

leimantas commented 1 year ago

@d-fence it works same. We use 0.12.6 for 2 years now.