odoo / docker

Other
955 stars 1.54k forks source link

[ADD] arm64v8 images #410

Closed derfl0 closed 1 year ago

derfl0 commented 2 years ago

Add specific arm64v8 images to allow native Odoo execution on arm architecture (e.g. M1)

semihalf-mazur-hubert commented 2 years ago

Hi, any updates about merging PR and providing official arm64 docker images?

FaisalJulaidan commented 2 years ago

Go ahead please and merge

leimantas commented 2 years ago
RUN WKH_VERSION=$([ "$(uname -m)" = 'aarch64' ] && echo "arm64" || echo "amd64") \
    && curl -o wkhtmltox.deb -sSL https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6-1/wkhtmltox_0.12.6-1.buster_${WKH_VERSION}.deb \
    && apt-get install -y --no-install-recommends ./wkhtmltox.deb \
    && rm -rf /var/lib/apt/lists/* wkhtmltox.deb
AaronBeaudoin commented 1 year ago

This is increasingly a very important addition for Odoo developers on macOS.

I'm currently having to write my own scripts to modify the official Dockerfile so that I can build my images natively.

jeffryjdelarosa commented 1 year ago

I already made the same problems , Please merge it

derfl0 commented 1 year ago

For anyone stumbling across this issue. I am now using GitHub actions (branch: build_action) to build the images automatically: https://hub.docker.com/r/fbieringer/odoo

Feel free to use. I try to keep everything up to date.

jeffryjdelarosa commented 1 year ago

@derfl0 Thanks so much 😍, do you have the Debbug settings with VScode, please I cloud pay it for it.

derfl0 commented 1 year ago

@derfl0 Thanks so much 😍, do you have the Debbug settings with VScode, please I cloud pay it for it.

https://github.com/derfl0/odoo_vscode_template

If you need more help with Odoo development, feel free to contact me via contact@bytist.de

d-fence commented 1 year ago

I'm sorry to say that it will not work. The only supported wkhtmltopdf version is 0.12.5-1.

leimantas commented 1 year ago

We use 0.12.6 for 2 years now. Everything works. No problems. Odoo 13,14,16. Arm based debian.

derfl0 commented 1 year ago

@d-fence @leimantas i can also confirm that I never had problems developing on my M1 using 12.6. Lately I was working on a lot of reports and never had any trouble. Of course this does not mean that it is perfectly fine but I would also argue that as long as there is no known issue one could assume that 12.6 in fact works as intended.

I am also pretty fine, if the arm images I compile ( https://hub.docker.com/r/fbieringer/odoo ) are defined as "unofficial" but maybe you could reference them somewhere on the official page so one could stumble across them.

It would also be really great, if you could externalise ODOO_RELEASE and ODOO_SHA from the Dockerimage so that it can be used for both images without requiring changes in the actual Dockerfile every time the source code is updated.

leimantas commented 1 year ago

@derfl0 you can build multiarch odoo images https://hub.docker.com/r/wbms/odoo-16.0/tags

derfl0 commented 1 year ago

@derfl0 you can build multiarch odoo images https://hub.docker.com/r/wbms/odoo-16.0/tags

That is true but I see no need to compile for amd64 since there is an official image for that and I would not try to mislead anyone into using an unofficial image just because they are lazy ;)

ludovic-gasc commented 1 year ago

Hi,

I made an attempt to support ARM for Odoo with another approach with this pull request: #466

I'm interested in your feedback.

ludovic-gasc commented 11 months ago

Hi all,

You can now test the ARM support of Odoo with the official container image: https://hub.docker.com/search?q=odoo&image_filter=official

Kind regards