search

odoo / docker

Other
931 stars 1.51k forks source link

[FIX] Odoo 14.0-16.0: don't pass parameters from the config to the command line #441

Closed bendem closed 3 months ago

bendem commented 1 year ago

Odoo will already use those values, passing them through the command line is not necessary. Note that if the values are not found in the config, the environment or default values are still passed, keeping the existing support for environment variables.

Fixes #334

I also fixed SC2068, not sure why DB_ARGS was quoted on one line and not the other.

lathama commented 3 months ago

@bendem would be nice to update this for 15, 16, and 17. I think adding the configuration entries to odoo.conf commented out would help explain the situation to users.

bendem commented 3 months ago

@bendem would be nice to update this for 15, 16, and 17. I think adding the configuration entries to odoo.conf commented out would help explain the situation to users.

That change is trivial and it's been a year, I'm not willing to put in more work if it's not considered for inclusion anyway.

lathama commented 3 months ago

@bendem thanks for the update, if you want to close this PR.