search

odoo / docker

Other
931 stars 1.51k forks source link

Update Dockerfile #470

Open freakynl opened 8 months ago

freakynl commented 8 months ago

Fixed version 14 code to be usable with proxy (is cleaner too).

This way one can set HTTP(S) proxy in ENV vars higher up and file and it will work. Most proxies won't allow the port GPG uses by default and it's not easy to get GPG working with proxy consistently in my tests.

This way it's not required and more conform instructions from PostgreSQL here: https://wiki.postgresql.org/wiki/Apt

lathama commented 3 months ago

@freakynl is this still relevant with 15, 16, and 17? If not please close.

freakynl commented 2 months ago

I didn't check but downloading keys via GPG servers doesn't start working magically via proxy (it's not HTTP/HTTPS and not using std allowed ports either) and I see no reason why you'd deviate from the PostgreSQL instructions like this in the first place. This deviation makes it less stable/predictable, doesn't work via proxy and doesn't seem to add anything useful at all from my perspective.

I provided this fix because an external party to us needed to build this on a build street that's behind a proxy. I don't use odoo. From my perspective it would be wise if you'd incorporate this and get proxy support with it and being more compatible with upstream instructions but do as you please.