odoo / docker

Other
931 stars 1.51k forks source link

Readme: obsolete docker flag (--link) #473

Open rossthom opened 8 months ago

rossthom commented 8 months ago

I want to run Odoo 16 from docker following the instructions written on the README file. When executing the command line on § 'Start an Odoo instance': $ docker run -p 8069:8069 --name odoo --link db:db -t odoo, I get the following docker error:

Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
Error: unknown flag: --link
See 'podman run --help'

the --link flag is deprecated : https://docs.docker.com/network/links/ The command line needs to be updated on the documentation.

abdelghani-djef commented 8 months ago

hi, it worked normal for me, did you run this one before ? : $ docker run -d -e POSTGRES_USER=odoo -e POSTGRES_PASSWORD=odoo -e POSTGRES_DB=postgres --name db postgres:15

rossthom commented 8 months ago

mh, I'll need to find some time to retry. I don't remember whether I used this exact command line.

lathama commented 3 months ago

@rossthom to update the Overview listed on Docker Hub you can create a PR editing the file https://github.com/docker-library/docs/blob/master/odoo/content.md

lathama commented 2 months ago

I am updating the content.md for some other issues and this is next in my queue. Brainstorming on how to word this here.

Currently

Start a PostgreSQL server

$ docker run -d -e POSTGRES_USER=odoo -e POSTGRES_PASSWORD=odoo -e POSTGRES_DB=postgres --name db postgres:15

Start an Odoo instance

$ docker run -p 8069:8069 --name odoo --link db:db -t odoo

Could Become

Start a network where the container names in the network are populated in `/etc/hosts`

$ docker network create my-odoo-network

Start a PostgreSQL server

$ docker run -d -e POSTGRES_USER=odoo -e POSTGRES_PASSWORD=odoo -e POSTGRES_DB=postgres --name db --net=my-odoo-network postgres:15

Start an Odoo instance

$ docker run -p 8069:8069 --name odoo --net=my-odoo-network -t odoo
amh-mw commented 2 months ago

I am updating the content.md for some other issues and this is next in my queue. Brainstorming on how to word this here.

Please open a pull request and I'll be happy to review there.