[FW][FIX] border: bottom sheet borders removed on DELETE_ROWS

fw-bot commented 1 week ago

[FIX] border: bottom sheet borders removed on DELETE_ROWS

Problem

Before this commit, when we add borders at the bottom of a sheet (at very the last rows), if we delete some rows in a position before the borders, some/all borders disappear (depending on how many rows we deleted). The reason being that the sheet plugin updates the total rows before we loop through them to shift the borders.

Solution

This commit fixes this behaviour by redefining the way we get the border to shift.

Task: 3911695

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4325

robodoo commented 1 week ago

fw-bot commented 1 week ago

@rachico @rrahir cherrypicking of pull request odoo/o-spreadsheet#4325 failed.

stdout:

Auto-merging src/plugins/core/borders.ts
Auto-merging tests/plugins/borders.test.ts
CONFLICT (content): Merge conflict in tests/plugins/borders.test.ts

stderr:

12:21:29.779386 git.c:463               trace: built-in: git cherry-pick 3c5924e2f441e6390112b9a3dc51e9437ee2b382 --strategy ort
error: could not apply 3c5924e2f... [FIX] border: bottom sheet borders removed on DELETE_ROWS
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot commented 1 week ago