odoo / o-spreadsheet

Other
175 stars 36 forks source link

[FW][FIX] parser: `parse` should handle unbounded references #4563

Closed fw-bot closed 3 days ago

fw-bot commented 3 days ago

The function parse could not handle unbounded references as it relied on tokenize and not rangeTokenize which is required.

Task: 4010920

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4562

robodoo commented 3 days ago

Pull request status dashboard

fw-bot commented 3 days ago

@rrahir @LucasLefevre cherrypicking of pull request odoo/o-spreadsheet#4562 failed.

stdout:

Auto-merging src/formulas/parser.ts
CONFLICT (content): Merge conflict in src/formulas/parser.ts
Auto-merging tests/evaluation/parser.test.ts

stderr:

13:12:59.266505 git.c:463               trace: built-in: git cherry-pick d28f0dddec569935f1a243e66dda8346888a384e --strategy ort
error: could not apply d28f0ddde... [FIX] parser: `parse` should handle unbounded references
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

rrahir commented 3 days ago

@robodoo r+