odoo / o-spreadsheet

Other
175 stars 36 forks source link

[REV] chart: avoid useless chart updates #4572

Closed hokolomopo closed 20 hours ago

hokolomopo commented 3 days ago

Description

This reverts commit 6eb43533d.

It turns out that checking the deep equality of runtime while ignoring functions is not a good fix to avoid useless chart updates. The problem is that some runtime changes apply only to the callbacks (eg. changing the dataset format only change the ticks callback).

The only real alternative would be to add the variables that are used in the callbacks to the runtime, so the deepEquals would work. But this is very error prone: we'll 100% forget to add a variable at some point.

So we will accept the useless updates for now, until we see a real performance issue.

Task: : 4029016

review checklist

robodoo commented 3 days ago

Pull request status dashboard