odoo / o-spreadsheet

Other
175 stars 36 forks source link

[FW][FIX] grid: prevent paste default #4574

Closed fw-bot closed 3 days ago

fw-bot commented 3 days ago

Followup of https://github.com/odoo/o-spreadsheet/pull/4298 The issue of the replacement of DOM elements still occured when we'd paste a chart is a specific way (see #How to reproduce). This commit ensures that the default paste behaviour is prevented when the lib has a custom handler, not just through the composer.

In this case, it is FigureContainer that is affected. After the paste effect, it replaces itself outside the visible part of its container GridOverlay. This issue would arise in Firefox and not Chromium-based browser. It to be linked to how the two handle the repositioning of static elements. This revision addresses this by setting the position of FigureContainer to absolute and not static.

How to reproduce: On Firefox,

Task: 3949903

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : 3949903

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4404

robodoo commented 3 days ago

Pull request status dashboard

fw-bot commented 3 days ago

This PR targets saas-17.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port