[FW][FIX] chart: cumulative not working for linear charts

fw-bot commented 2 days ago

Description

The cumulative chart option was not working for line charts with a linear/time axis.

This was because the data in the linear charts runtime was an array of objects {x, y} rather than an array of numbers, and this wasn't properly handled in the cumulative computations.

Task: : 4028957

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4568

robodoo commented 2 days ago

fw-bot commented 2 days ago

@hokolomopo @pro-odoo cherrypicking of pull request odoo/o-spreadsheet#4568 failed.

stdout:

Auto-merging src/helpers/figures/charts/line_chart.ts
Auto-merging tests/figures/chart/chart_plugin.test.ts
CONFLICT (content): Merge conflict in tests/figures/chart/chart_plugin.test.ts

stderr:

12:50:46.250399 git.c:463               trace: built-in: git cherry-pick f24af5914fe56aa10ef49502a824a3970956fefc --strategy ort
error: could not apply f24af5914... [FIX] chart: cumulative not working for linear charts
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

hokolomopo commented 2 days ago

@robodoo r+

odoo / o-spreadsheet

[FW][FIX] chart: cumulative not working for linear charts #4579

Description

review checklist