odoo / o-spreadsheet

Other
175 stars 36 forks source link

[FIX] functions: allow to match empty cells #4580

Closed LucasLefevre closed 1 day ago

LucasLefevre commented 2 days ago

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : 4023057

review checklist

robodoo commented 2 days ago

Pull request status dashboard

laa-odoo commented 1 day ago

the behavior that "*" does not catch empty cells while "<>..." catches them seems weird to me. However this is the behavior observed on Excel and Google.

This therefore makes me say that the code which was added specifically to resolve this case should not be there. But that the behavior observed on Google and Excel must be the side effect of code used on a larger scale.

to see if, depending on the difficulty encountered on the fwp, the fix should not be done elsewhere

laa-odoo commented 1 day ago

@robodoo r+

LucasLefevre commented 1 day ago

I cherry-picked the commits in master: everything is fine :ok_hand:

robodoo commented 1 day ago

@LucasLefevre @laa-odoo because this PR has multiple commits, I need to know how to merge it:

LucasLefevre commented 1 day ago

robodoo rebase-ff

robodoo commented 1 day ago

Merge method set to rebase and fast-forward.