[FIX] CF: Ignore errors thrown during CF evaluation

[rrahir]

How to reproduce:

• Add a CF of type "single color"
• Input an invalid formula as its value
• save the CF

-> the whole grid crashes

Historically, the CF evaluation was wrapped in a try-catch statement and it was removed https://github.com/odoo/o-spreadsheet/pull/3380 as it seemed unnecessary. Unfortunately, since there is no check on the formula validity when we create the CF, the call to compile can crash.

A future improvement (targetting master) will align the behaviour of "cellIsRule" with the other CF type ("ColorScaleRule" and "IconSetRule") and catch invalid formulas in the allowDispatch.

Task: 4036921

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

• [ ] feature is organized in plugin, or UI components
• [ ] support of duplicate sheet (deep copy)
• [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
• [ ] in model/UI: ranges are strings (to show the user)
• [ ] undo-able commands (uses this.history.update)
• [ ] multiuser-able commands (has inverse commands and transformations where needed)
• [ ] new/updated/removed commands are documented
• [ ] exportable in excel
• [ ] translations (_t("qmsdf %s", abc))
• [ ] unit tested
• [ ] clean commented code
• [ ] track breaking changes
• [ ] doc is rebuild (npm run doc)
• [ ] status is correct in Odoo

[robodoo]

[LucasLefevre]

robodoo fw=no

improved in saas-17.1 with https://github.com/odoo/o-spreadsheet/pull/2932

[robodoo]

Forward-port disabled.

[LucasLefevre]

robodoo fw=master ?

[robodoo]

@LucasLefevre unknown fw configuration 'master'.

For your own safety I've ignored everything in your entire comment.

Currently available commands:

command
help	displays this help
r(eview)+	approves the PR, if it's a forwardport also approves all non-detached parents
r(eview)=<number>	only approves the specified parents
fw=no	does not forward-port this PR
fw=default	forward-ports this PR normally
fw=skipci	does not wait for a forward-port's statuses to succeed before creating the next one
up to <branch>	only ports this PR forward to the specified branch (included)
merge	integrate the PR with a simple merge commit, using the PR description as message
rebase-merge	rebases the PR on top of the target branch the integrates with a merge commit, using the PR description as message
rebase-ff	rebases the PR on top of the target branch, then fast-forwards
squash	squashes the PR as a single commit on the target branch, using the PR description as message
delegate+	grants approval rights to the PR author
delegate=<...>	grants approval rights on this PR to the specified github users
default	stages the PR normally
priority	tries to stage this PR first, then adds default PRs if the staging has room
alone	stages this PR only with other PRs of the same priority
cancel=staging	automatically cancels the current staging when this PR becomes ready
override=<...>	marks overridable statuses as successful
check	fetches or refreshes PR metadata, resets mergebot state

Note: this help text is dynamic and will change with the state of the PR.

[LucasLefevre]

Thanks robodoo!

robodoo fw=default

[robodoo]

Waiting for CI to create followup forward-ports.