odoo / o-spreadsheet

Other
180 stars 39 forks source link

[FW][FIX] border: bottom sheet borders removed on DELETE_ROWS #4604

Closed fw-bot closed 3 weeks ago

fw-bot commented 3 weeks ago

[FIX] border: bottom sheet borders removed on DELETE_ROWS

Problem

Before this commit, when we add borders at the bottom of a sheet (at very the last rows), if we delete some rows in a position before the borders, some/all borders disappear (depending on how many rows we deleted). The reason being that the sheet plugin updates the total rows before we loop through them to shift the borders.

Solution

This commit fixes this behaviour by redefining the way we get the border to shift.

Task: 3911695

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4603 Forward-Port-Of: odoo/o-spreadsheet#4325

robodoo commented 3 weeks ago

Pull request status dashboard

fw-bot commented 3 weeks ago

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port