Closed fw-bot closed 3 months ago
This PR targets saas-17.3 and is part of the forward-port chain. Further PRs will be created up to master.
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
@hokolomopo @LucasLefevre the next pull request (odoo/o-spreadsheet#4617) is in conflict. You can merge the chain up to here by saying
@robodoo r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
@robodoo r+
Description
This reverts commit 6eb43533d.
It turns out that checking the deep equality of runtime while ignoring functions is not a good fix to avoid useless chart updates. The problem is that some runtime changes apply only to the callbacks (eg. changing the dataset format only change the ticks callback).
The only real alternative would be to add the variables that are used in the callbacks to the runtime, so the deepEquals would work. But this is very error prone: we'll 100% forget to add a variable at some point.
So we will accept the useless updates for now, until we see a real performance issue.
Task: : 4029016
review checklist
Forward-Port-Of: odoo/o-spreadsheet#4602 Forward-Port-Of: odoo/o-spreadsheet#4572