odoo / o-spreadsheet

Other
193 stars 44 forks source link

[FW][FIX] pivot: support empty values #4710

Closed fw-bot closed 2 months ago

fw-bot commented 2 months ago

Steps to reproduce:

=> The cells corresponding to empty values are empty.

Implementation note: The pivot helper toNormalizedPivotValue takes groupValue as argument, but the type of groupValue is variable. It's either a CellValue or a FunctionResultObject. This is not ideal and should be fixed in the future.

Task: 4053215

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4685

robodoo commented 2 months ago

Pull request status dashboard

fw-bot commented 2 months ago

@pro-odoo @hokolomopo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

pro-odoo commented 2 months ago

robodoo r+

robodoo commented 2 months ago

@pro-odoo @hokolomopo 'ci/runbot' failed on this reviewed PR.

pro-odoo commented 2 months ago

robodoo r+

fw-bot commented 2 months ago

@pro-odoo @hokolomopo this PR was modified / updated and has become a normal PR. It must be merged directly.