[FW][FIX] composer: layout break when composer assistant is opened

fw-bot commented 2 months ago

Description:

When typing =S in the composer, the composer assistant will open. If there wasn't enough space on right (default 300px width), this would break the layout. This PR addresses the issue by adding a width check for the composer assistant. If the width condition is met, the style right: 0px is applied to prevent the layout from breaking.

Task: : 4037213

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4715 Forward-Port-Of: odoo/o-spreadsheet#4666

robodoo commented 2 months ago

fw-bot commented 2 months ago

@dhrp-odoo @hokolomopo cherrypicking of pull request odoo/o-spreadsheet#4666 failed.

stdout:

Auto-merging src/components/composer/composer/composer.ts
CONFLICT (content): Merge conflict in src/components/composer/composer/composer.ts

stderr:

15:15:51.882062 git.c:463               trace: built-in: git cherry-pick a33bdf7606c135191ebe99219b0402403787635d --strategy ort
error: could not apply a33bdf760... [FIX] composer: layout break when composer assistant is opened
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

dhrp-odoo commented 2 months ago

@robodoo r+

odoo / o-spreadsheet

[FW][FIX] composer: layout break when composer assistant is opened #4718

Description:

review checklist