[PERF] history: faster history at import

LucasLefevre commented 2 months ago

Description:

The history is sometimes used in plugin import methods: this.history.update(...)

There are 2 main reason to do that:

data structures are typed as readonly (to force using the history when handling commands)
it's easier since it creates all intermediary objects itself this.history.update("myData", sheetId, pivotId, value), if myData is empty, it will creates intermediary objects with keys sheetId and pivotId: myData: { [sheetId]: { [pivotId]: data } }

At import however, keeping track of the changes is useless. They are currently aggregated in the changes array, but never used.

This commit improves loading time of the large number data set by ~17%

Before: 1353ms After: 1116ms

(averages over 8 runs) Task: : 4083517

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

robodoo commented 2 months ago

rrahir commented 2 months ago

very elegant :o

rrahir commented 2 months ago

@robodoo r+