Closed fw-bot closed 2 months ago
@LucasLefevre @rrahir this PR targets master and is the last of the forward-port chain.
To merge the full chain, use
@robodoo r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
robodoo r+
On Tue, Jul 30, 2024 at 3:55 PM Otis - Odoo Forward-Port Steward [bot] < @.***> wrote:
@LucasLefevre https://github.com/LucasLefevre @rrahir https://github.com/rrahir this PR targets master and is the last of the forward-port chain.
To merge the full chain, use
@robodoo https://github.com/robodoo r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
— Reply to this email directly, view it on GitHub https://github.com/odoo/o-spreadsheet/pull/4732#issuecomment-2258413993, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTHFEPOQQVFJ5GYCNOE5K3ZO6LNLAVCNFSM6AAAAABLWN4IOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYGQYTGOJZGM . You are receiving this because you were mentioned.Message ID: @.***>
Description:
The history is sometimes used in plugin
import
methods:this.history.update(...)
There are 2 main reason to do that:
this.history.update("myData", sheetId, pivotId, value)
, ifmyData
is empty, it will creates intermediary objects with keyssheetId
andpivotId
:myData: { [sheetId]: { [pivotId]: data } }
At import however, keeping track of the changes is useless. They are currently aggregated in the
changes
array, but never used.This commit improves loading time of the large number data set by ~17%
Before: 1353ms After: 1116ms
(averages over 8 runs) Task: : 4083517
review checklist
Forward-Port-Of: odoo/o-spreadsheet#4731 Forward-Port-Of: odoo/o-spreadsheet#4727