[FW][FIX] tests: remove toLocaleString from test

fw-bot commented 2 months ago

Since 17.3, the baseline of scorecards is correctly formatted with the spreadsheet's locale instead of using toLocaleString().

The tests were still testing with toLocaleString(), causing them to fail in a french locale.

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4489

robodoo commented 2 months ago

fw-bot commented 2 months ago

@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

LucasLefevre commented 2 months ago

robodoo r+

On Tue, Jul 30, 2024 at 4:31 PM robodoo @.***> wrote:

[image: Pull request status dashboard] https://mergebot.odoo.com/odoo/o-spreadsheet/pull/4733

— Reply to this email directly, view it on GitHub https://github.com/odoo/o-spreadsheet/pull/4733#issuecomment-2258501489, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTHFEMY7JBWAVB5CHRBQY3ZO6PT7AVCNFSM6AAAAABLWQKHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYGUYDCNBYHE . You are receiving this because you were mentioned.Message ID: @.***>

odoo / o-spreadsheet

[FW][FIX] tests: remove toLocaleString from test #4733

Description:

review checklist