[FW][FIX] ranges: getRangeFromSheetXC with invalid sheetId

fw-bot commented 2 months ago

Description

When getRangeFromSheetXC is called, it either crashes or returns an corrupted range. The getter should handle this case, and return an invalid range.

Task: : 3578461

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4275

robodoo commented 2 months ago

fw-bot commented 2 months ago

@hokolomopo @rrahir cherrypicking of pull request odoo/o-spreadsheet#4275 failed.

stdout:

Auto-merging src/plugins/core/range.ts
Auto-merging tests/plugins/range.test.ts
CONFLICT (content): Merge conflict in tests/plugins/range.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

hokolomopo commented 2 months ago

@robodoo r+

odoo / o-spreadsheet

[FW][FIX] ranges: getRangeFromSheetXC with invalid sheetId #4773

Description

review checklist