search

odoo / o-spreadsheet

Other
193 stars 44 forks source link

[FW][FIX] evaluation: handle throwing error on each vectorized position #4798

Closed fw-bot closed 2 months ago

fw-bot commented 2 months ago

Before this commit, if an error was throw when evaluating a vectorized formula, then the evaluation stopped and only the cell with the formula was marked as an error. No other values ​​were spread.

This behavior is functionally false, because depending on the arguments passed, it is possible that on this vector position, the evaluation does not return an error.

This commit changes that by making sure to try for each vector position if the evaluation works. Even though it only spreads errors in certain cases.

Task: : 4091276

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4768

robodoo commented 2 months ago

Pull request status dashboard

fw-bot commented 2 months ago

@laa-odoo @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

LucasLefevre commented 2 months ago

robodoo r+

On Thu, Aug 8, 2024 at 4:47 PM robodoo @.***> wrote:

[image: Pull request status dashboard] https://mergebot.odoo.com/odoo/o-spreadsheet/pull/4798

— Reply to this email directly, view it on GitHub https://github.com/odoo/o-spreadsheet/pull/4798#issuecomment-2276016386, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTHFEMRDVD5AXPBLKTUEKDZQOAIRAVCNFSM6AAAAABMGU4EKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWGAYTMMZYGY . You are receiving this because you were mentioned.Message ID: @.***>