odoo / o-spreadsheet

Other
193 stars 44 forks source link

[FW][FIX] parser: parsing empty string throws meaningful error #4829

Closed fw-bot closed 2 months ago

fw-bot commented 2 months ago

Description:

parse("") throws an error like cannot ready property of undefined.

Note that it doesn't cause any (known) real bug, but let's make it more robust nonetheless.

With this commit, it throws a user friendly message.

Task: : TASK_ID

review checklist

Forward-Port-Of: odoo/o-spreadsheet#4827 Forward-Port-Of: odoo/o-spreadsheet#4825

robodoo commented 2 months ago

Pull request status dashboard

fw-bot commented 2 months ago

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port