[FW][FIX] composer: Pivot cell selection non adapted to locale

fw-bot commented 2 months ago

How to reproduce:

Open a sheet with a =pivot() formula
Change the locale to french
Start editing a cell with "="
Select a cell from the pivot formula

-> The formulat argument separator is set to comma and not a semicolon

Task: 4104502

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4792

robodoo commented 2 months ago

fw-bot commented 2 months ago

@rrahir @LucasLefevre cherrypicking of pull request odoo/o-spreadsheet#4792 failed.

stdout:

Auto-merging src/components/composer/composer/abstract_composer_store.ts
CONFLICT (content): Merge conflict in src/components/composer/composer/abstract_composer_store.ts
Auto-merging tests/composer/composer_store.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

rrahir commented 2 months ago

@robodoo r+

odoo / o-spreadsheet

[FW][FIX] composer: Pivot cell selection non adapted to locale #4834

Description:

review checklist