Closed fw-bot closed 2 months ago
@rachico @LucasLefevre cherrypicking of pull request odoo/o-spreadsheet#4789 failed.
stdout:
Auto-merging src/components/side_panel/table_panel/table_panel.ts
CONFLICT (content): Merge conflict in src/components/side_panel/table_panel/table_panel.ts
Auto-merging src/components/side_panel/table_panel/table_panel.xml
Auto-merging tests/table/table_panel_component.test.ts
CONFLICT (content): Merge conflict in tests/table/table_panel_component.test.ts
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
In the former case, you may want to edit this PR message as well.
:warning: after resolving this conflict, you will need to merge it via @robodoo.
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
robodoo r+
[FIX] table: fix bug when edit table with invalid range
Before this commit, when editing a table and entering an invalid range, the entire spreadsheet stops working and causes the browser to crash. This is due to an infinite call to
onWillUpdateProps
of theSelectionInput
component.This commit fixes the problem by removing a useless range validity check when the input changes.
Task: 4102425
review checklist
Forward-Port-Of: odoo/o-spreadsheet#4789