[FW][FIX] pivot: mark pivot as invalid if column name is empty

fw-bot commented 2 months ago

Steps to reproduce, given a range with some data:

Replace the column title by a formula resulting in an empty string (="")
select the entire range and insert a pivot table => unexpected error: An unexpected error occurred. Submit a support ticket at odoo.com/help. Field undefined does not exist

This was caused by the verification function of the column name, which only checked if the column name was empty, but a cell with a formula can return an empty string, which is not the same as an empty cell.

Task: 4116392

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

[ ] feature is organized in plugin, or UI components
[ ] support of duplicate sheet (deep copy)
[ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
[ ] in model/UI: ranges are strings (to show the user)
[ ] undo-able commands (uses this.history.update)
[ ] multiuser-able commands (has inverse commands and transformations where needed)
[ ] new/updated/removed commands are documented
[ ] exportable in excel
[ ] translations (_t("qmsdf %s", abc))
[ ] unit tested
[ ] clean commented code
[ ] track breaking changes
[ ] doc is rebuild (npm run doc)
[ ] status is correct in Odoo

Forward-Port-Of: odoo/o-spreadsheet#4862

robodoo commented 2 months ago

fw-bot commented 2 months ago

@pro-odoo @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

LucasLefevre commented 2 months ago

robodoo r+

On Tue, Aug 20, 2024 at 2:56 PM Otis - Odoo Forward-Port Steward [bot] < @.***> wrote:

@pro-odoo https://github.com/pro-odoo @LucasLefevre https://github.com/LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo https://github.com/robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

— Reply to this email directly, view it on GitHub https://github.com/odoo/o-spreadsheet/pull/4867#issuecomment-2298795020, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTHFEI42Q6NLB533TZLS4LZSM4H5AVCNFSM6AAAAABMZ3FIFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYG44TKMBSGA . You are receiving this because you were mentioned.Message ID: @.***>

odoo / o-spreadsheet

[FW][FIX] pivot: mark pivot as invalid if column name is empty #4867

Description:

review checklist